-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update K8s dependency go modules for K8s v1.26.0-rc.0 #389
Update K8s dependency go modules for K8s v1.26.0-rc.0 #389
Conversation
Welcome @sunnylovestiramisu! |
Hi @sunnylovestiramisu. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Did the script generate the PR title? I would probably clarify that this is updating the Kubernetes dependencies |
Yes it does, we can specify whatever title we want. |
dfdf1ae
to
ed99ee4
Compare
@sunnylovestiramisu Thanks for the PR.. but few comments from my end. imo, we dont bring |
@humblec Thank you for the information! :) So the dependabot has already covered both the script release-tools/update-vendor.sh and release-tools/go-get-kubernetes.sh? Then we should update the documentation: csi-release-tools/blob/master/SIDECAR_RELEASE_PROCESS.md ? |
@humblec I'm not sure if dependabot can handle kubernetes version updating (at least I have not seen it https://github.com/kubernetes-csi/external-provisioner/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed). |
In terms of whether we should wait for 1.26.0, I think it's fine to update to rc.0 now, and then update once more to 1.26.0 before we do the final release. That way we can start running tests with the new deps sooner. I don't expect signficant changes between rc.0 and .0 |
ed99ee4
to
391d4b8
Compare
Oh.. yes, it can - as long as its not excluded in package list.. we can also see such instance here . https://github.com/kubernetes-csi/volume-data-source-validator/pulls @msau42 |
Ok.. if the plan is to get the tests run early, it should be fine . 👍 |
go.mod
Outdated
k8s.io/kube-openapi v0.0.0-20221110221610-a28e98eb7c70 // indirect | ||
k8s.io/utils v0.0.0-20221108210102-8e77b1f39fe2 // indirect | ||
sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect | ||
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | ||
sigs.k8s.io/yaml v1.3.0 // indirect | ||
) | ||
|
||
replace k8s.io/api => k8s.io/api v0.26.0-rc.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its better to remove this replace section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the script is relying on the replace statements to do special handling for the kubernetes libraries that don't follow the same version naming scheme. @pohly do you know if it is safe to skip this logic if the repo does not import k/k?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the repo doesn't use k/k, then it should be safe to drop the replace statements.
391d4b8
to
5271348
Compare
5271348
to
d980d6f
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sunnylovestiramisu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-none |
Ran